fix(next): Stop using NextUrl to avoid type conflict across version #62
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
|
😬 Makes sense. Do you have any ideas on other ways to manage the dependencies of examples so we don't have conflicts if we need more changes? Perhaps we just need 1 example app each for next 13 and next 14 so it's just ignored once? |
|
Yeh I've been thinking about this. I've copied the idea from how Next.js does it at https://github.com/vercel/next.js/tree/canary/examples - they have more lightweight examples without the default files e.g. images, CSS, etc, so I'd like to do that. We should probably have just a single example app for each major version and also merge in app / pages dirs as well. Then we can more easily manage the ignore list. I'd also like to have e2e tests on them as part of CI so we don't need to manually test every endpoint every time. But these are separate tasks! I suggest merging this and we can tackle these in a new issue. |
|
I don't see a good way to make dependabot ignore just next 13 inside that example. I think we'll need to do more work to separate the workspace members from the examples so dependabot can manage each example individually. |
Fixes #42
This removes the
NextRequest["nextUrl"]usage from our code, which causes TypeScript compilation problems across different versions of Next.This seems to be due to the
NextUrltype using an internal symbol that TS sees as uinque across different versions. We should take care to remember that if we ever try to use symbols in the future.I've also added a next.js 13 example that uses
withArcjetto wrap some routes.